Re: Odd oid-system-column handling in postgres_fdw

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Odd oid-system-column handling in postgres_fdw
Date: 2016-08-30 01:55:28
Message-ID: ba6ea8c0-9daa-87e2-5770-8c0af300e703@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016/08/26 22:35, Heikki Linnakangas wrote:
> On 04/05/2016 11:15 AM, Etsuro Fujita wrote:
>> On 2016/03/16 16:25, Etsuro Fujita wrote:
>>> PG9.5 allows us to add an oid system column to foreign tables, using
>>> ALTER FOREIGN TABLE SET WITH OIDS, but currently, that column reads as
>>> zeroes in postgres_fdw. That seems to me like a bug. So, I'd like to
>>> propose to fix that, by retrieving that column from the remote server
>>> when requested. I'm attaching a proposed patch for that.

>> I rebased the patch against HEAD. Updated patch attached.

> Committed, thanks!

Thank you for taking the time to commit this patch!

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-08-30 02:04:31 Re: Renaming of pg_xlog and pg_clog
Previous Message Dave Cramer 2016-08-30 01:07:25 Re: [PATCH] Send numeric version to clients