| From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review of Writeable CTE Patch |
| Date: | 2010-02-03 16:41:42 |
| Message-ID: | b42b73151002030841pc4446d7kee1b80ed0d349a54@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 3, 2010 at 11:18 AM, Marko Tiikkaja
<marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> wrote:
> On 2010-02-03 16:53 UTC+2, Robert Haas wrote:
>> Some thoughts:
>>
>> The comments in standard_ExecutorStart() don't do a good job of
>> explaining WHY the code does what it does - they just recapitulate
>> what you can already see from reading the code. You say "If there are
>> DML WITH statements, we always need to use the CID and copy the
>> snapshot." That's self-evident from the following code. What's not
>> clear is why this is necessary, and the comment doesn't make any
>> attempt to explain it. The second half of the if statement has the
>> same problem.
>
>
> Right. The documentation in its current state is definitely lacking.
> I've tried to focus all the time I have in making this patch technically
> good.
Outside of documentation issues, where do we stand? Do you need help
with the documentation?
merlin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2010-02-03 16:43:53 | Re: [CFReview] Red-Black Tree |
| Previous Message | Tim Bunce | 2010-02-03 16:31:30 | Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH] |