Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

From: Jeremy Drake <pgsql(at)jdrake(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Date: 2011-09-01 15:42:46
Message-ID: alpine.BSO.2.00.1109010839300.27326@resin.csoft.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Thu, 1 Sep 2011, Bruce Momjian wrote:

> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo
> > > builfarm member.
> >
> > mongoose is still crashing, so it must have been some other aspect of
> > commit 4bd7333 that caused this.
>
> Agreed.  Let me look some more.  Odd this succeeds:
>
> 	okapi 	  	Gentoo 1.12.14 icc 11.1.072 x86_64
>
> but this fails:
>
> 	mongoose 	Gentoo 1.6.14 icc 9.0.032 i686
>
> The backtrace:
>
> 	http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoose&dt=2011-09-01%2013%3A45%3A01
>
> shows it failing on this line:
>
> 	size = offsetof(NDBOX, x[0]) +sizeof(double) * 2;
>
> so I wonder if this is some compiler bug.  offsetof is:
>
> 	((long) &((type *)0)->field)
>
> and the struct is:
>
> 	typedef struct NDBOX
> 	{
> 	    int32       vl_len_;        /* varlena header (do not touch directly!) */
> 	    unsigned int dim;
> 	    double      x[1];
> 	} NDBOX;
>
> That "x" is quite a common symbol.  Is there any way to get access to
> this machine?  Should I just revert it all and see what happens?
>
>

I am the owner of both mongoose and okapi.  Let me know if there's
anything you want me to try.


In response to

Responses

pgsql-hackers by date

Next:From: Robert TreatDate: 2011-09-01 16:05:40
Subject: Re: Informix FDW - anybody working on this?
Previous:From: Bruce MomjianDate: 2011-09-01 14:53:51
Subject: Re: Removal of useless include references

pgsql-committers by date

Next:From: Tom LaneDate: 2011-09-01 15:57:55
Subject: pgsql: Put back improperly removed #include.
Previous:From: Bruce MomjianDate: 2011-09-01 15:21:26
Subject: pgsql: Add C comment about necessary NetBSD include.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group