Re: commit and rollback don't throw exceptions when they should

From: Kris Jurka <books(at)ejurka(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: taktos <taktos(at)gmail(dot)com>, Oliver Jowett <oliver(at)opencloud(dot)com>, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: commit and rollback don't throw exceptions when they should
Date: 2009-11-18 11:21:38
Message-ID: alpine.BSO.2.00.0911180619360.13019@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Wed, 4 Nov 2009, Kevin Grittner wrote:

> Having received no feedback on the preliminary patch I previously
> posted, I'll suggest this (fairly minimal) patch. I didn't attempt to
> deal with the distributed transaction issue, since it seemed pretty
> messy and I wasn't sure the fix was worth the mess it would make. As
> far as I can see, it should fix the OP's problem, although it would be
> nice to get a confirmation of that.
>

I've commited a modified version of this patch to HEAD only, because
changing this behavior could break peoples applications.

I extended the check for the connection already being closed to the other
connection methods. There's no reason commit/rollback are special here.
I also needed to fix a regression testcase which was violating this rule.

Kris Jurka

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Kris Jurka 2009-11-18 14:29:50 Re: BUG #5177: Concurrency problem in AbstractJdbc23PooledConnection
Previous Message Maciek Sakrejda 2009-11-17 17:40:34 COPY and turning off autocommit