Le 12 avr. 05, à 08:23, Rémi Zara a écrit :
> With the following patch, the crash still occurs in the same way. But
> it does seem, reading the code, that it still may be necessary.
Well, I've re-run the checks several times after a clean make and it
does not crash anymore. So the patch seems to help !
Please consider applying it.
> RCS file: /projects/cvsroot/pgsql/src/port/snprintf.c,v
> retrieving revision 1.26
> diff -u -r1.26 snprintf.c
> --- snprintf.c 20 Mar 2005 13:54:53 -0000 1.26
> +++ snprintf.c 12 Apr 2005 06:08:02 -0000
> @@ -222,7 +222,7 @@
> /* Create enough structures to hold all arguments */
> for (p = format; *p != '\0'; p++)
> - if (*p == '%') /* counts %% as two,
> so overcounts */
> + if ((*p == '%') || (*p == '*')) /* counts %%
> as two, so overcounts */
> /* Need to use malloc() because memory system might not be
> started yet. */
> Rémi Zara
> Le 11 avr. 05, à 22:31, Tom Lane a écrit :
>> =?ISO-8859-1?Q?R=E9mi_Zara?= <remi_zara(at)mac(dot)com> writes:
>>> The crash occurs in pg_sprintf, work on which has been done
>>> march 11th....
>> Offhand I'd bet it's overrunning its malloc'd arrays because the loop
>> the top doesn't count "*" as needing a fmtpos position.
>> regards, tom lane
> Rémi Zara
In response to
pgsql-hackers by date
|Next:||From: Chris Campbell||Date: 2005-04-14 20:28:50|
|Subject: New wal_sync_method for Darwin?|
|Previous:||From: Greg Stark||Date: 2005-04-14 19:55:47|
|Subject: Re: Interactive docs idea|
pgsql-patches by date
|Next:||From: OpenMacNews||Date: 2005-04-14 20:26:41|
|Subject: pgsql config flag update: apple rendezvous renamed bonjour|
|Previous:||From: Mark Kirkwood||Date: 2005-04-14 09:33:39|
|Subject: Re: Proof of concept for MIN/MAX optimization|