Re: Cleaning up unreferenced table files

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Cleaning up unreferenced table files
Date: 2005-04-27 14:33:52
Message-ID: Pine.OSF.4.61.0504271721060.70462@kosh.hut.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 27 Apr 2005, Tom Lane wrote:

> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> On Tue, 26 Apr 2005, Tom Lane wrote:
>>> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>>>> I feel that crashes that leaves behind stale files are rare.
>>>
>>> Indeed, and getting more so all the time ...
>
>> How so? Have changes been made in those parts of the code?
>
> No, just that the overall reliability of Postgres keeps improving.
>
> At the time that TODO entry was created, I don't think we even had the
> ability to roll back table creates/drops properly, so there were
> scenarios in which unreferenced files could be left behind without even
> assuming any software error. And the prevalence of backend crashes was
> way higher than it is now, too. So I think a good argument could be
> made that the TODO item isn't nearly as important as it was at the time.

*shrug*. I won't push any harder if you feel strongly against the patch.

Should we just remove the TODO item? And/or document the issue?

- Heikki

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-04-27 16:39:44 Re: [HACKERS] Continue transactions after errors in psql
Previous Message Tom Lane 2005-04-27 14:15:00 Re: Cleaning up unreferenced table files