On Thu, 23 Aug 2007, Tom Lane wrote:
> "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
>> - readstopwords calls recode_and_lowerstr directly, instead of using the
>> "wordop" function pointer in StopList struct. All callers used
>> recode_and_lowerstr anyway, so this simplifies the code a little bit. Is
>> there any external dictionary implementations that would require
>> different behavior?
> I don't think eliminating wordop altogether is such a hot idea; some
> dictionary could possibly want to do different processing than that.
> Something that was annoying me yesterday was that it was not clear
> whether we had fixed every single place that uses a tsearch config file
> to assume that the file is in UTF8 and should be converted to database
> encoding. So I was thinking of hardwiring the "recode" part into
> readstopwords, and using wordop just for the "lowercase" part, which
> seemed to me like a saner division of labor. That is, UTF8 is a policy
> that we want to enforce globally, but lowercasing maybe not, and this
> still leaves the door open for more processing besides lowercasing.
> Oleg, Teodor, what do you think about this?
I agrre with utf-8 recoding and please, don't lowercase. Dictionaries
are very different.
> regards, tom lane
Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru),
Sternberg Astronomical Institute, Moscow University, Russia
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(495)939-16-83, +007(495)939-23-83
In response to
pgsql-patches by date
|Next:||From: Zdenek Kotala||Date: 2007-08-23 19:50:01|
|Subject: Re: pg_ctl configurable timeout|
|Previous:||From: Tom Lane||Date: 2007-08-23 16:17:23|
|Subject: Re: BUG #3571: call to decrypt causes segfault |