| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Eddie Stanley <eddiewould(at)paradise(dot)net(dot)nz>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, mux(at)elvis(dot)mu(dot)org |
| Subject: | Re: Frustrating issue with PGXS |
| Date: | 2007-06-26 14:42:35 |
| Message-ID: | Pine.LNX.4.64.0706261635470.8254@briare.cri.ensmp.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Let's add the ifndef to Makefile.global and change the
> existing extension makefiles to
>
> PG_CONFIG := pg_config
> PGXS := $(shell $(PG_CONFIG) --pgxs)
> include $(PGXS)
>
> Any objections?
Maybe the ":=" for pg_config is not necessary, "=" is fine for a
simple string definition ?
Some documentation (not just code) update seems important to me. The patch
I sent which describes the current status may be applied to existing
branches, and something else can be written for the explicit PG_CONFIG
setting.
Otherwise it looks okay AFAIC.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2007-06-26 14:45:05 | Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords |
| Previous Message | Gregory Stark | 2007-06-26 14:31:04 | Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords |