Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] segfault caused by heimdal (was: SUSE port)

From: Reinhard Max <max(at)suse(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] segfault caused by heimdal (was: SUSE port)
Date: 2005-01-12 19:11:32
Message-ID: Pine.LNX.4.61.0501121957480.23538@wotan.suse.de (view raw or flat)
Thread:
Lists: pgsql-announcepgsql-hackerspgsql-patches
Sorry for following up to myself once more...

On Wed, 12 Jan 2005 at 19:36, Reinhard Max wrote:

> The problem is, that the heimdal implementation of kerberos5 used on 
> sles8 needs an extra include statement for com_err.h in 
> src/interfaces/libpq/fe-auth.c to get the prototype for 
> error_message(), while on newer SUSE-releases using the MIT 
> Kerberos5 implementation this prototype is provided by krb5.h 
> itself.

after finding and reading the thread on HACKERS about com_err.h from 
last December, I think either should configure check if including 
krb5.h is sufficient for getting the prototype of error_message(), or 
a conditional include for krb5.h should be added to 
src/interfaces/libpq/fe-auth.c.

A proposed patch to achieve the latter is attached to this mail.

Either way will lead to a build time error when error_message() isn't 
declared or com_err.h can't be found, which is better than the current 
situation where only a warning about a missing prototype is issued, 
but compilation continues resulting in a broken libpq.


cu
	Reinhard

Attachment: postgresql-krb5.patch
Description: text/plain (351 bytes)

In response to

Responses

pgsql-announce by date

Next:From: Greg StarkDate: 2005-01-12 19:23:44
Subject: Re: Much Ado About COUNT(*)
Previous:From: Jonah H. HarrisDate: 2005-01-12 18:55:29
Subject: Re: Much Ado About COUNT(*)

pgsql-hackers by date

Next:From: Greg StarkDate: 2005-01-12 19:23:44
Subject: Re: Much Ado About COUNT(*)
Previous:From: Jonah H. HarrisDate: 2005-01-12 18:55:29
Subject: Re: Much Ado About COUNT(*)

pgsql-patches by date

Next:From: Greg StarkDate: 2005-01-12 19:23:44
Subject: Re: Much Ado About COUNT(*)
Previous:From: Jonah H. HarrisDate: 2005-01-12 18:55:29
Subject: Re: Much Ado About COUNT(*)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group