| From: | Gavin Sherry <swm(at)alcove(dot)com(dot)au> |
|---|---|
| To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Bitmapscan changes |
| Date: | 2007-03-13 01:26:15 |
| Message-ID: | Pine.LNX.4.58.0703131220340.26060@linuxworld.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Mon, 12 Mar 2007, Heikki Linnakangas wrote:
> Here's a patch to change the amgetmulti API so that it's called only
> once per scan, and the indexam adds *all* matching tuples at once to a
> caller-supplied TIDBitmap. Per Tom's proposal in July 2006:
> http://archives.postgresql.org/pgsql-hackers/2006-07/msg01233.php
I incorporated something like your change to gistnext(). This is much
better, for the reason Teodor mentions up thread.
The return type of gistnext() is int and it is possible that it could
overflow (on some platforms) now that there is no max_tids.
Thanks,
Gavin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-03-13 01:40:14 | Re: autovacuum next steps, take 3 |
| Previous Message | Tom Lane | 2007-03-13 01:26:10 | Re: [COMMITTERS] pgsql: Make configuration parameters fall back to their default values |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ITAGAKI Takahiro | 2007-03-13 06:00:16 | pgbench on mingw needs fflush |
| Previous Message | Gavin Sherry | 2007-03-13 01:02:47 | Re: Updated bitmap index patch |