On Mon, 12 Jun 2006, Tom Lane wrote:
> "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> > AllocateFile() and AllocateDir() should return the control to the caller
> > since we might want to upgrade the elevel.
> That is not what we do for upgrading errors. Use a critical section in
> a caller that doesn't want elog(ERROR).
True, but current code just check the return value of AllocateABC() then
decide to upgrade elevel to FATAL. This is ok if we allow AllocateABC()
don't elog(ERROR) themselves.
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2006-06-13 01:47:45|
|Subject: Re: minor fix of elevel in fd.c |
|Previous:||From: Bruce Momjian||Date: 2006-06-13 01:23:51|
|Subject: Re: Bitmap index AM|