Re: Include tablespace information in psql \d footers

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Include tablespace information in psql \d footers
Date: 2004-06-28 17:29:47
Message-ID: Pine.LNX.4.58.0406290328510.24362@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Fri, 25 Jun 2004, Tom Lane wrote:

> Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > Attached.
>
> Couple of problems with this:
>
> 1. Don't #ifndef WIN32 it. In the first place, we might have tablespace
> support on Windows later, and in the second place, even if psql is
> running on Windows that doesn't mean the server it's talking to is.

Oops.

>
> 2. Printing "pg_default" when reltblspace is zero is wrong. Get the
> database's default tablespace and print that. Or perhaps better,
> don't print anything at all; that would avoid cluttering the display
> for people who don't use tablespaces.

Ahhh yes of course. Attached is a patch with docs which excludes reporting
of the default tablespace.

Gavin

Attachment Content-Type Size
psql_tablespace2.diff text/plain 7.1 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2004-06-28 20:58:57 PITR Archive Recovery
Previous Message Andrew Dunstan 2004-06-28 16:58:03 Re: plperl patch