Re: [PATCHES] ALTER TABLE ... SET TABLESPACE

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] ALTER TABLE ... SET TABLESPACE
Date: 2004-06-20 21:17:20
Message-ID: Pine.LNX.4.58.0406210712030.12730@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Sun, 20 Jun 2004, Tatsuo Ishii wrote:

> > > Attached is a patch implementing this functionality.
> > >
> > > I've modified make_new_heap() as well as swap_relfilenodes() to not assume
> > > that tablespaces remain the same from old to new heap. I thought it better
> > > to go down this road than introduce a lot of duplicate code.
> >
> > I have tried your patches and it works great. Thanks.
> >
> > One thing I noticed was if I change tablespace for a table having
> > indexes, they are left in the old tablespace and the table itself was
> > moved to the new tablespace. I regard this is a good thing since I
> > could assign different table spaces for table and indexes.
> > It would be even better to assign different tablespaces for each
> > index.
>
> Hm. It seems there's a problem with tablespaces. What I did was:
>
> pgbench -i test
> alter table accounts set tablespace mydb2;
> \d accounts
>
> backend crashes by signal 11...

I seem to be clobbering memory some where but I cannot get assert or
valgrind to tell me. Anyone got any ideas?

Gavin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-06-20 21:18:48 Re: nested xacts and phantom Xids
Previous Message Dave Page 2004-06-20 21:15:20 Re: Compile failure with SSL

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-20 21:18:48 Re: nested xacts and phantom Xids
Previous Message Dave Page 2004-06-20 21:15:20 Re: Compile failure with SSL