Re: Minor DROP TABLESPACE issue

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Minor DROP TABLESPACE issue
Date: 2004-06-19 01:52:32
Message-ID: Pine.LNX.4.58.0406191145570.11676@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 18 Jun 2004, Tom Lane wrote:

> Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > Is it really that bad? NamespaceCreate() could just touch a file at
> > pg_tablespaces/<tablespaceoid>/<MyDatabaseId>/<namespace oid> and
> > RemoveSchema() could remove it.
>
> No, because that wouldn't be rollback-safe. You'd have to make the
> placeholder file act enough like a real relation that the smgr
> delete-at-commit-or-abort mechanisms could handle it. So then you
> have to buy into not having its name actually collide with any real
> relations, which is where I started feeling like I didn't want to
> pursue that solution.
>
> This is certainly doable in theory, it just seems like much more
> complexity than the problem is worth ...

Oh yeah... I forgot about OID wrap around issues and integration into WAL,
etc, wouldn't be great fun.

If we just wanted to make the error message more user friendly, perhaps we
could *gulp* store the tablespace name in PG_VERSION. Then again, all of
this can probably be handled better in the manual.

Gavin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-06-19 02:04:44 Re: Minor DROP TABLESPACE issue
Previous Message Bruce Momjian 2004-06-19 01:47:43 Re: Tablespace patch review