Skip site navigation (1) Skip section navigation (2)

Re: fix of some issues with multi-line query editing

From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>, <alvherre(at)commandprompt(dot)com>
Subject: Re: fix of some issues with multi-line query editing
Date: 2006-03-13 08:47:32
Message-ID: Pine.LNX.4.44.0603131139340.11667-100000@lnfm1.sai.msu.ru (view raw or flat)
Thread:
Lists: pgsql-patches
On Sun, 12 Mar 2006, Tom Lane wrote:

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> 3) Fix the handling of commands with not closed brackets, quotes, double 
> >> quotes. (now those commands are not splitted in parts...)
> 
> Really?  CVS tip seems to treat a multiline command as a single history
> entry *unless* it contains newlines within quoted strings (including
> single, double, dollar quotes) or newlines within /* comments.


Bruce have NOT applied MY patch, which really contained the fixes of the
described problems... So, I'm waiting for it...

> 
> I think this patch is seriously broken, and I don't agree with what it's
> trying to accomplish in the first place --- I still haven't found any
> cases where it's an improvement to pull back multiple lines as one
> history entry.  For example, if you made a mistake on the fifth line of
> a ten-line CREATE TABLE command, the current code makes it extremely
> inconvenient to fix that: you have to back-arrow or forward-arrow
> tediously over five lines, where before you could pull back one line at
> a time and just edir the line that needed fixing.

(you do always Ctrl+Left_arrow ... to do that faster...) I don't see
anything bad here, that's the normal way to do it...

Regards, 

	Sergey

*****************************************************
Sergey E. Koposov
Max Planck Institute for Astronomy
Web: http://lnfm1.sai.msu.ru/~math 
E-mail: math(at)sai(dot)msu(dot)ru


In response to

Responses

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2006-03-13 11:43:31
Subject: Re: Proposed patch for error locations
Previous:From: ITAGAKI TakahiroDate: 2006-03-13 08:38:01
Subject: Re: [PATCHES] Automatic free space map filling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group