Re: Call for port reports

Bruce Momjian writes:

> It is time for people to report their port testing. Please test against
> current CVS or beta5 and report your 'uname -a'.

For a change, here is one that does not work:

HP-UX hpunix5 B.11.00 U 9000/803 2002765023

Using the system compiler, I get several complaints about our use of
"inline", for example:

cc -Ae +O2 -I../../../../src/include -D_XOPEN_SOURCE_EXTENDED -c -o dynahash.o dynahash.c
cc: "dynahash.c", line 466: error 1000: Unexpected symbol: "calc_bucket".
cc: panic 2017: Cannot recover from earlier errors, terminating.

I had to patch it as follows to get it to work:

diff -ur ../cvs-pgsql/src/backend/utils/hash/dynahash.c ./src/backend/utils/hash/dynahash.c
--- ../cvs-pgsql/src/backend/utils/hash/dynahash.c 2003-08-19 03:13:41.000000000 +0200
+++ ./src/backend/utils/hash/dynahash.c 2003-10-31 11:05:05.000000000 +0100
@@ -462,7 +462,7 @@

/* Convert a hash value to a bucket number */
-static inline uint32
+static uint32
calc_bucket(HASHHDR *hctl, uint32 hash_val)
{
uint32 bucket;
diff -ur ../cvs-pgsql/src/backend/utils/sort/tuplesort.c ./src/backend/utils/sort/tuplesort.c
--- ../cvs-pgsql/src/backend/utils/sort/tuplesort.c 2003-08-17 21:58:06.000000000 +0200
+++ ./src/backend/utils/sort/tuplesort.c 2003-10-31 11:10:12.000000000 +0100
@@ -1784,7 +1784,7 @@
/*
* Inline-able copy of FunctionCall2() to save some cycles in sorting.
*/
-static inline Datum
+static Datum
myFunctionCall2(FmgrInfo *flinfo, Datum arg1, Datum arg2)
{
FunctionCallInfoData fcinfo;
@@ -1816,7 +1816,7 @@
* and return a 3-way comparison result. This takes care of handling
* NULLs and sort ordering direction properly.
*/
-static inline int32
+static int32
inlineApplySortFunction(FmgrInfo *sortFunction, SortFunctionKind kind,
Datum datum1, bool isNull1,
Datum datum2, bool isNull2)

Any ideas?

--
Peter Eisentraut peter_e(at)gmx(dot)net