| From: | Dennis Björklund <db(at)zigo(dot)dhs(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: String changes |
| Date: | 2003-03-08 21:36:12 |
| Message-ID: | Pine.LNX.4.44.0303082230160.27526-100000@zigo.dhs.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Sat, 8 Mar 2003, Tom Lane wrote:
> Yeah, but making those printfs different from the others is a recipe
> for future mistakes. I thought that proposed patch was useless
> micro-optimization, too.
The reason to remove it is to help the translators.
When I find the string "\n" in the translation file I have to look that up
in the source to understand what it is and what it should be translated
to. Of course I could just translate it to "\n" but my experience as a
translator tells me that it's usually a sign of a misstake. When there is
many translations, and each translator has the same problem, then it may
be worth it to remove it.
It has nothing to do with the 0.00001s it takes to do the call to gettext.
--
/Dennis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-03-08 22:09:17 | Re: String changes |
| Previous Message | Joe Conway | 2003-03-08 20:38:52 | new typeconv example (was [HACKERS] More outdated documentation) |