Skip site navigation (1) Skip section navigation (2)

Re: inline newNode()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: inline newNode()
Date: 2002-10-11 23:07:04
Message-ID: Pine.LNX.4.44.0210120047180.928-100000@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian writes:

> Peter Eisentraut wrote:
> > Bruce Momjian writes:
> >
> > > I assume the GEQO results he is seeing is only for a tests, and that the
> > > macro version of newNode will help in all cases.
> >
> > Well are we just assuming here or are we fixing actual problems based on
> > real analyses?
>
> What is your point?  He is testing GEQO, but I assume other places would
> see a speedup from inlining newNode.

That's exactly my point: You're assuming.

Of course everything would be faster if we inline it, but IMHO that's the
compiler's job.

-- 
Peter Eisentraut   peter_e(at)gmx(dot)net


In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-10-11 23:35:14
Subject: Re: inline newNode()
Previous:From: Giles LeanDate: 2002-10-11 22:54:48
Subject: Re: contrib/fixchar (Was: Large databases, performance)

pgsql-patches by date

Next:From: Peter EisentrautDate: 2002-10-11 23:07:52
Subject: Re: INSTALL updates
Previous:From: Bruce MomjianDate: 2002-10-11 17:41:55
Subject: Re: INSTALL updates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group