Re: [PATCH] Cleanup of JDBC character encoding

From: Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se>
To: Barry Lind <barry(at)xythos(dot)com>
Cc: <pgsql-jdbc(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCH] Cleanup of JDBC character encoding
Date: 2001-07-10 10:35:26
Message-ID: Pine.LNX.4.33.0107101226570.4394-100000@sensenet.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

On Mon, 9 Jul 2001, Barry Lind wrote:

> Anders,
>
> I have some issues with this patch.
>
> 1) Please don't require the driver to perform yet another round trip to
> the server to get the database encoding. You changed the following code
> which accessed the server once at connection creation:
[snip]
> 2) I don't like having test specific code in Encoding.java, specifically
> the dummy encoding 'X-UNIT-TESTS'.

Thanks Barry, I'll fix these things and return with a new patch.

I think I'll be able to get pretty good test coverage even without the
extra test data.

/Anders
_____________________________________________________________________
A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
Stockholm, Sweden

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Anders Bengtsson 2001-07-10 12:31:43 Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Previous Message Thomas Lockhart 2001-07-10 02:27:06 Re: Re: Backups WAS: 2 gig file size limit

Browse pgsql-patches by date

  From Date Subject
Next Message Anders Bengtsson 2001-07-10 12:31:43 Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Previous Message Thomas Lockhart 2001-07-10 02:27:06 Re: Re: Backups WAS: 2 gig file size limit