Bruce Momjian writes:
> > What should we do? The only remaining issue is a non-8-bit-clean
> > memcmp, which seems pretty easy to fix it.
> OK, here is a patch to allow SunOS to pass the regression tests.
At a glance, this patch looks okay. However, since this issue does not
represent a regression from 7.1 I'm not exactly in favour of installing it
now. We want to get a release out, so I think we need to get stricter in
those matters. And this patch is not exactly trivial.
> One interesting item is that I had to compile with
> backend/utils/adt/varbit.c with -fno-builtin because my gcc 2.X manual
Yeah, if you use GCC with optimization on SunOS 4 then the issue should be
moot because the GCC version is used. However, I don't think that's the
setup in question.
This is actually a good situation to show that configuring with one kind
of compiler flag and building with another is not reliable, even if it's
only the optimization level.
Peter Eisentraut peter_e(at)gmx(dot)net
In response to
pgsql-hackers by date
|Next:||From: Peter Eisentraut||Date: 2001-12-19 18:46:40|
|Subject: Re: SunOS4 port|
|Previous:||From: Peter Eisentraut||Date: 2001-12-19 18:45:54|
|Subject: Re: [PATCHES] Problem compiling postgres sql --with-tcl |
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2001-12-19 19:01:40|
|Subject: Re: SunOS patch for memcmp()|
|Previous:||From: Tom Lane||Date: 2001-12-19 18:46:00|
|Subject: Re: Patch to fix float8 test on FreeBSD/alpha |