Re: encoding names

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>
Subject: Re: encoding names
Date: 2001-08-17 16:11:00
Message-ID: Pine.LNX.4.30.0108171803290.677-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Karel Zak writes:

> - possible is use synonyms for encoding (an example ISO-8859-1,
> Latin1, l1)

On the choice of synonyms: Do we really want to add that many synonyms
that are not the standard name? I think the following are not necessary:

cyrillic, cp819, ibm819, isoir100x, l1-4

ISO 8859 is a pretty well-know term these days.

KOI8 needs to be aliased as koi8r. Unicode is not a valid encoding name,
actually. Do you know what encoding is stands for and could you add that
as an alias?

On the code:

#ifdef WIN32
#include "win32.h"
#else
#include <unistd.h>
#endif

needs to be written as

#ifdef WIN32
# include "win32.h"
#else
# include <unistd.h>
#endif

for portability.

For extra credit: A patch to configure and the documentation.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-08-17 16:39:04 Re: Re: Rough idea for supporting "sequencename.nextval" syntax
Previous Message Ross J. Reedstrom 2001-08-17 16:08:32 Re: Re: Rough idea for supporting "sequencename.nextval" syntax

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-17 17:34:32 Re: Re: [JDBC] JDBC pg_description update needed for CVS tip
Previous Message Bruce Momjian 2001-08-17 15:38:58 Re: Re: [HACKERS] Re: WIN32 errno patch