Re: encode in base code

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: encode in base code
Date: 2001-07-02 17:50:45
Message-ID: Pine.LNX.4.30.0107021944340.677-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Marko Kreen writes:

> Put encode() into base system. Used part of Alex' patch
> for docs, hope he does not mind ;)

Please use #include "", not #include <>, for PostgreSQL's header files.

Would you mind changing the copyright to match the rest of the source?

Put everything in encode.c (not varlena.c), and put encode.c in utils/adt.

I think we've covered before that 'uint' is not a standard data type.
VARSIZE is of type int32 (signed).

To convert from text to C string, use textout().

Also, I think the term "encode" is already overloaded for multibyte use.
Maybe it needs to be qualified, such as "binary_encode".

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2001-07-02 19:36:47 Re: encode in base code
Previous Message Bruce Momjian 2001-07-02 16:44:52 Re: encode in base code