Skip site navigation (1) Skip section navigation (2)

Re: Python (PyGreSQL) make install patch

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Python (PyGreSQL) make install patch
Date: 2001-06-22 18:39:28
Message-ID: Pine.LNX.4.30.0106222024430.727-200000@peter.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
[The updated proposed new makefile for interfaces/python is attached.]

[May 30th] Jason Tishler writes:

> I like your proposed Makefile for many reasons: consistent with the
> rest of the PostgreSQL make infrastructure, easy to understand, DESTDIR
> support, etc.  However, PostgreSQL is now burdened with determining and
> maintaining the Python shared extension cruft for all supported platforms.
> I am quite willing to supply the Cygwin stuff, but you are on your own
> for other platforms like AIX, etc.

AFAICT, we build shared libraries on AIX okay.

> See attached for patches that are necessary for Cygwin.

> @@ -13,7 +13,7 @@ include $(top_srcdir)/src/Makefile.shlib
>  override CFLAGS += $(CFLAGS_SL)
>  # (Python also has a config.h file.  Be sure to use ours.)
>  override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS) -I$(python_includedir)
> -SHLIB_LINK = $(libpq)
> +SHLIB_LINK = $(libpq) $(python_libspec)
>
>  all: all-lib

I'm not sure about this change.  $(python_libspec) is to link an embedded
python, e.g., it includes -lpython itself.  I'm not sure this would work
everywhere, since the module will be loaded by a python interpreter, so
you could get conflicts.  Does this correspond to what the current "gmake
all" gives you?

>     $(exec-prefix)/lib/python$(version)/site-packages
>
> is the place for third-party modules.

I have since found supporting documentation for this.

-- 
Peter Eisentraut   peter_e(at)gmx(dot)net   http://funkturm.homeip.net/~peter

Attachment: newmakefile
Description: text/plain (1.7 KB)

In response to

Responses

pgsql-patches by date

Next:From: Dave CramerDate: 2001-06-22 19:09:40
Subject: RE: Re: [ADMIN] High memory usage [PATCH]
Previous:From: Marko KreenDate: 2001-06-22 16:29:14
Subject: Re: use GUC for cmdline

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group