Re: Re: [PATCHES] Australian timezone configure option

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Thomas Lockhart <lockhart(at)fourpalms(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Chris Dunlop <chris(at)onthe(dot)net(dot)au>, Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] Australian timezone configure option
Date: 2001-06-12 16:19:05
Message-ID: Pine.LNX.4.30.0106121805430.756-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Thomas Lockhart writes:

> Before hacking the rather carefully evolved static tables let's consider
> how to support time localization generally (e.g. language-specific names
> for months). In the meantime, a compile-time solution for more easily
> setting the "CST" interpretation would seem to be an incremental
> improvement for "buildability" (and this has already been submitted).

I'm not particularly happy about "popularizing" that compile time option
beyond its current state (i.e., get in and edit config.h), and there's a
reason why I haven't done it myself yet.

--enable-xxx type configure options should, as a matter of principle, not
replace one behaviour by another. (The proposed option replaces U.S.
rules by Australian rules.) In this case it might look like a minor
issue, but it's a slippery slope. For one thing, packages build by
Australians will cease to behave reasonably in the rest of the world.
That is the same reason why we don't want people altering NAMEDATALEN and
BLCKSZ from configure.

A run-time option seems like the appropriate solution.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-06-12 16:21:39 Re: Re: [PATCHES] Australian timezone configure option
Previous Message Bruce Momjian 2001-06-12 16:15:22 Re: Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-06-12 16:21:39 Re: Re: [PATCHES] Australian timezone configure option
Previous Message Bruce Momjian 2001-06-12 16:15:22 Re: Re: [PATCHES] Fw: Isn't pg_statistic a security hole - Solution Proposal