Re: Fix for defaults in createuser

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix for defaults in createuser
Date: 2001-01-21 10:56:19
Message-ID: Pine.LNX.4.30.0101211152550.757-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian writes:

> ! if [ $REPLY = "y" -o $REPLY = "Y" ]; then
>
> fixed to:
>
> ! if [ "$REPLY" = "y" -o "$REPLY" = "Y" ]; then

Good.

FYI, it's never necessary to quote the right side of a shell variable
assignment.

FOO=$BAR

always works, as does

case $foo in ...

But it doesn't hurt of course.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-01-21 13:56:49 Re: Fix for defaults in createuser
Previous Message Denis Perchine 2001-01-21 07:09:46 Re: Re: [PATCHES] Patch to support transactions with BLOBs for current CVS