Skip site navigation (1) Skip section navigation (2)

pltcl and plpython memory leak revisited (fwd)

From: "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk>
To: pgsql-patches(at)postgresql(dot)org
Subject: pltcl and plpython memory leak revisited (fwd)
Date: 2002-10-09 16:31:13
Message-ID: Pine.LNX.4.21.0210091728550.9364-300000@ponder.fairway2k.co.uk (view raw or flat)
Thread:
Lists: pgsql-patches

I don't remember seeing any acknowledgement or comments on this. It isn't on
the unapplied patches list either so I'm assuming it got lost somewhere.


---------- Forwarded message ----------
Date: Fri, 4 Oct 2002 11:50:46 +0100 (BST)
From: Nigel J. Andrews <nandrews(at)investsystems(dot)co(dot)uk>
To: pgsql-patches(at)postgresql(dot)org
Subject: pltcl and plpython memory leak revisited



I have attached two patches as per:

1) pltcl:
Add SPI_freetuptable() calls to avoid memory leaks (Me + Neil Conway)
Change sprintf()s to snprintf()s (Neil Conway)
Remove header files included elsewhere (Neil Conway)

2)plpython:
Add SPI_freetuptable() calls to avoid memory leaks
Cosemtic change to remove a compiler warning


Notes:

I have tested pltcl.c for
 a) the original leak problem reported for the repeated call of spi_exec in a
TCL fragment
and b) the subsequent report resulting from the use of spi_exec -array in a TCL
fragment.

The plpython.c patch is exactly the same as that applied to make revision 1.23,
the plpython_schema.sql and feature.expected sections of the patch are also the
same as last submited, applied and subsequently reversed out. It remains
untested by me (other than via make check). However, this should be safe
provided PyString_FromString() _copies_ the given string to make a PyObject.


-- 
Nigel J. Andrews
Director

---
Logictree Systems Limited
Computer Consultants

Attachment: plpython.freett.patch
Description: text/plain (2.8 KB)
Attachment: pltcl.freett.patch
Description: text/plain (14.4 KB)

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-10-09 16:53:06
Subject: Re: pltcl and plpython memory leak revisited (fwd)
Previous:From: Bruce MomjianDate: 2002-10-09 16:27:44
Subject: Re: Doc Updates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group