David Reid writes:
> Here is the first batch of files and diffs for the BeOS port.
Looks pretty straightforward, just some minor comments. I'd be happy to
help with anything.
Please avoid any #ifdef __BEOS__ etc as much as possible. For example,
there isn't a good reason to do this
typedef char bool;
@@ -80,6 +84,7 @@
#define false ((bool) 0)
+#endif /* __BEOS__ */
typedef bool *BoolPtr;
unless your compiler is broken.
To include SupportDefs.h, create a configure test for it.
Please no -DBEOS, especially when __BEOS__ seems to be predefined. If you
need to define this to get certain symbols defined in system header files,
do it in configure.in; look at AC_AIX as an example.
Also, please add comments to all platform specific stuff. Why do you
define AF_UNIX to 1? Is it not predefined, or does BEOS have no domain
sockets (in which case you have more work to do)?
Also, patches should usually be formed with diff -cr to get them all into
Peter Eisentraut Sernanders väg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
In response to
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2000-06-09 03:18:10|
|Subject: Re: Ordinal suffix behaviour|
|Previous:||From: Giles Lean||Date: 2000-06-08 21:48:25|
|Subject: Re: Ordinal suffix behaviour |