Skip site navigation (1) Skip section navigation (2)

Re: BeOS Files & diff's

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: David Reid <dreid(at)jetnet(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: BeOS Files & diff's
Date: 2000-06-09 00:57:36
Message-ID: Pine.LNX.4.21.0006090240070.23619-100000@localhost.localdomain (view raw or flat)
Thread:
Lists: pgsql-patches
David Reid writes:

> Here is the first batch of files and diffs for the BeOS port.

Looks pretty straightforward, just some minor comments. I'd be happy to
help with anything.

Please avoid any #ifdef __BEOS__ etc as much as possible. For example,
there isn't a good reason to do this

+#ifndef __BEOS__
 #ifndef __cplusplus
 #ifndef bool
 typedef char bool;
@@ -80,6 +84,7 @@
 #ifndef false
 #define false  ((bool) 0)
 #endif
+#endif /* __BEOS__ */
 typedef bool *BoolPtr;

unless your compiler is broken.

To include SupportDefs.h, create a configure test for it.

Please no -DBEOS, especially when __BEOS__ seems to be predefined. If you
need to define this to get certain symbols defined in system header files,
do it in configure.in; look at AC_AIX as an example.

Also, please add comments to all platform specific stuff. Why do you
define AF_UNIX to 1? Is it not predefined, or does BEOS have no domain
sockets (in which case you have more work to do)?

Also, patches should usually be formed with diff -cr to get them all into
one file.


-- 
Peter Eisentraut                  Sernanders väg 10:115
peter_e(at)gmx(dot)net                   75262 Uppsala
http://yi.org/peter-e/            Sweden


In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2000-06-09 03:18:10
Subject: Re: Ordinal suffix behaviour
Previous:From: Giles LeanDate: 2000-06-08 21:48:25
Subject: Re: Ordinal suffix behaviour

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group