Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] COMMENT ON patch

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Mike Mascari <mascarim(at)yahoo(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] COMMENT ON patch
Date: 1999-10-24 18:57:51
Message-ID: Pine.LNX.4.10.9910242042040.377-100000@peter-e.yi.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Oct 23, Mike Mascari mentioned:

> The following patch extends the COMMENT ON functionality to the
> rest of the database objects beyond just tables, columns, and views. The
> grammer of the COMMENT ON statement now looks like:
> 
> COMMENT ON [ 
>   [ DATABASE | INDEX | RULE | SEQUENCE | TABLE | TYPE | VIEW ] <objname> |
> 
>   COLUMN <relation>.<attribute> |
>   AGGREGATE <aggname> <aggtype> | 
>   FUNCTION <funcname> (arg1, arg2, ...) | 
>   OPERATOR <op> (leftoperand_typ rightoperand_typ) | 
>   TRIGGER <triggername> ON relname> 
> ] IS 'text'

In related news I'd like to point out that psql's \dd command now supports
aggregates, functions, operators, types, relations (tables, views,
indices, sequences), rules, and triggers. In addition all the other \d?
commands (\da, \df, \dT, \do, \dtvsiS), as well as \l, have comments
display switchable. Attribute comments can be seen in \d in a similar
fashion. You can also give a comment on \lo_import which can then be seen
in \lo_list (=\dl). Seems like all the bases are covered.

Just to confirm a few things here: Are you keying rule comments on
pg_rewrite.oid? Are operator comments keyed on the oid of the underlying
function? (Perhaps that could even be changed so you can put a comment on
the operator and a note like "implementation of %^*& operator" on the
function. Just a thought.)

Now we just have to stick a whole bunch of comments on all system stuff.
Where would be a good place to do this? Where are all the comments on the
built-in operators generated?

	-Peter

-- 
Peter Eisentraut                  Sernanders vaeg 10:115
peter_e(at)gmx(dot)net                   75262 Uppsala
http://yi.org/peter-e/            Sweden


Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 1999-10-24 20:15:51
Subject: Re: [HACKERS] RFC: Industrial-strength logging
Previous:From: Tim HollowayDate: 1999-10-24 18:22:34
Subject: Logging - events supported

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group