Skip site navigation (1) Skip section navigation (2)

MemoryContextCheck()

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: MemoryContextCheck()
Date: 2000-07-10 18:25:25
Message-ID: Pine.LNX.3.96.1000710194407.17283A-101000@ara.zf.jcu.cz (view raw or flat)
Thread:
Lists: pgsql-patches
 Here is the patch with memory leak checker. This checker allow detect
in-chunk leaks, overwrite-next-chunk leaks and overwrite block-freeptr leaks.

A in-chunk leak --- if something overwrite space after wanted (via palloc()
size, but it is still inside chunk. For example 

	x = palloc(12);		/* create 16b chunk */
	memset(x, '#', 13);

this leak is in the current source total invisible, because chunk is 16b and
leak is in the "align space".

 For this feature I add data_size to StandardChunk, and all memory which go
from AllocSetAlloc() is marked as 0x7F.

 The MemoryContextCheck() is compiled '#ifdef USE_ASSERT_CHECKING'. 

I add this checking to 'tcop/postgres.c' and is active after each backend
query, but it is probably not sufficient, because some MemoryContext exist
only during memory processing --- will good if someone who known where
it is needful (Tom:-) add it for others contexts;

 A problem in the current source is that we have still some malloc()
allocation that is not needful and this allocation is total invisible for
all context routines. For example Dllist in backend (pretty dirty it is in
catcache where values in Dllist are palloc-ed, but list is malloc-ed).
--- and BTW. this Dllist design stand in the way for query cache :-)

 Tom, if you agree I start replace some mallocs.

 BTW. --- Tom, have you idea for across transaction presistent allocation for
          SQL functions? (like regex - now it is via malloc) 


 I almost forget. I add one if() to AllocSetAlloc(), for 'size' that are 
greater than ALLOC_BIGCHUNK_LIMIT is not needful check AllocSetFreeIndex(), 
because 'fidx' is always 'ALLOCSET_NUM_FREELISTS - 1'. It a little brisk up 
allocation for very large chunks. Right?
 
						Karel

Attachment: mem_check-07102000.patch.gz
Description: application/x-gzip (3.8 KB)

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2000-07-10 18:49:51
Subject: Re: PostgreSQL BSDI BSD/OS port
Previous:From: Stephan SzaboDate: 2000-07-09 19:32:11
Subject: ALTER TABLE ADD CHECK ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group