Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] pgbench not setting scale size correctly?

From: Greg Smith <gsmith(at)gregsmith(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [GENERAL] pgbench not setting scale size correctly?
Date: 2008-05-09 07:51:19
Message-ID: Pine.GSO.4.64.0805090328070.1819@westnet.com (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-patches
On Wed, 7 May 2008, Bruce Momjian wrote:

> Tom Lane wrote:
>> Greg Smith <gsmith(at)gregsmith(dot)com> writes:
>>> The way the option parsing code is done would make complaining in the case
>>> where your parameter is ignored a bit of a contortion.
>>
>> Yeah.  But couldn't we have that part issue a warning if -s had been set
>> on the command line?
>
> Patch attached that issues a warning.

Turns out it wasn't so contorted.  Updated patch attached that only warns 
in the exact cases where the setting is ignored, and the warning says how 
it's actually setting the scale.  I tested all the run types and it 
correctly complains only when warranted, samples:

$ ./pgbench -s 200 -i pgbench
creating tables...
10000 tuples done. ...

$ ./pgbench -s 100 pgbench
Scale setting ignored by standard tests, using database branch count
starting vacuum...end.
transaction type: TPC-B (sort of)
scaling factor: 200 ...

$ ./pgbench -s 100 -f select.sql pgbench
starting vacuum...end.
transaction type: Custom query
scaling factor: 100 ...

--
* Greg Smith gsmith(at)gregsmith(dot)com http://www.gregsmith.com Baltimore, MD

Attachment: pgbench-warn.txt
Description: text/plain (586 bytes)

In response to

Responses

pgsql-patches by date

Next:From: KaiGai KoheiDate: 2008-05-09 10:10:32
Subject: Re: [0/4] Proposal of SE-PostgreSQL patches
Previous:From: Bruce MomjianDate: 2008-05-09 03:26:21
Subject: Re: [NOVICE] encoding problems

pgsql-general by date

Next:From: Christian.StroblDate: 2008-05-09 08:31:48
Subject: reproducible database crash with simple sql command on postgres 8.3.1
Previous:From: Luca FerrariDate: 2008-05-09 07:28:21
Subject: Re: regexp_replace in two times?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group