| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | John Lister <john(dot)lister-ps(at)kickstone(dot)com> |
| Cc: | pgsql-jdbc(at)postgresql(dot)org |
| Subject: | Re: Unit test patches |
| Date: | 2009-05-03 16:42:52 |
| Message-ID: | Pine.BSO.4.64.0905031241160.20196@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
On Fri, 1 May 2009, John Lister wrote:
> The first occurs in DatabaseMetaDataTest.testTables line 104:
>
> It fetches all the columns for any table beginning with test - i happen to
> have other tables named test... which causes this to fail. I've modified it
> to look for the testmetadata table, alternatively the docs should be altered
> to state that the test database should be clean.
It is expected that the test database is empty.
> The second in TimeTest.timeTest : line 269 & 283:
> The timezone tests fail because the as it happens local daylight savings is
> in effect, the code tries to test for this by submitting the time being
> tested, but this actually works out daylight savings for the time at the
> epoch (1/1/1970). I've modified it to use DST_OFFSET instead (note - this
> may fail if ran during the switchover period).
What timezone are you running the tests in? I don't see them
in US/Pacific. Reproducing the failure would help.
Kris Jurka
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Lister | 2009-05-03 17:50:45 | Re: Very strange performance decrease when reusing a PreparedStatement |
| Previous Message | Péter Kovács | 2009-05-03 16:28:53 | Re: Very strange performance decrease when reusing a PreparedStatement |