Skip site navigation (1) Skip section navigation (2)

Re: Any reason to have heap_(de)formtuple?

From: Kris Jurka <books(at)ejurka(dot)com>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Any reason to have heap_(de)formtuple?
Date: 2008-10-28 21:23:57
Message-ID: Pine.BSO.4.64.0810281721500.6833@leary.csoft.net (view raw or flat)
Thread:
Lists: pgsql-hackers

On Tue, 28 Oct 2008, Zdenek Kotala wrote:

> Kris Jurka napsal(a):
>> 
>> Here's a patch that changes everything over to the the new API and 
>> implements the old API by calling the new API.
>
> It seems to me OK. I have only one comment. I prefer to pfree allocated 
> memory for temporary nulls array. I think that caller could call old API 
> many times without memory context cleanup.
>

Here's an incremental patch to add the suggested pfreeing.

Kris Jurka

Attachment: pfree-bool-arrays-for-htup-api.patch
Description: text/plain (1.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Hannu KrosingDate: 2008-10-28 21:25:40
Subject: Re: PostgreSQL + Replicator developer meeting 10/28
Previous:From: Martin PihlakDate: 2008-10-28 21:12:17
Subject: Re: contrib/pg_stat_statements

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group