| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | Eric Lenio <eric(at)lenio(dot)net> |
| Cc: | Marek Lewczuk <newsy(at)lewczuk(dot)com>, pgsql-jdbc <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: AbstractJdbc2Array - another patch |
| Date: | 2007-11-22 06:26:56 |
| Message-ID: | Pine.BSO.4.64.0711220119340.30460@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
On Thu, 22 Nov 2007, Eric Lenio wrote:
> Kris/Marek: I've attached a very small followup patch which addresses a
> need I had: I was using java.sql.DatabaseMetaData's getColumns method to
> attempt to get the COLUMN_SIZE attribute for a column of type "character
> varying(255) []". Without my patch (applied after Kris's patches) the
> COLUMN_SIZE would be 2147483647, with the patch it would be 255. I am
> by no means a JDBC or Postgresql expert, so maybe I am way off base.
> What do you think?
>
Looks reasonable, but way too specific. We don't want to do that for each
array type. At the top of each of the methods that have the switch
statements we should have something that checks to see if it is an array
type and converts the oid to the oid of the base type.
Kris Jurka
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marek Lewczuk | 2007-11-22 11:07:07 | Re: AbstractJdbc2Array - another patch |
| Previous Message | Eric Lenio | 2007-11-22 06:09:06 | Re: AbstractJdbc2Array - another patch |