Re: Patch to improve Cloneable implementation on classes which extend PGobject.

From: Kris Jurka <books(at)ejurka(dot)com>
To: Russell Francis <rfrancis(at)ev(dot)net>
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch to improve Cloneable implementation on classes which extend PGobject.
Date: 2007-07-16 15:03:19
Message-ID: Pine.BSO.4.64.0707161102590.32311@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Mon, 16 Jul 2007, Russell Francis wrote:

> Kris Jurka wrote:
>>
>> On Sun, 24 Jun 2007, Russell Francis wrote:
>>
>>> The attached patch aims to improve the current implementation of the
>>> clone() method on classes which extend PGobject.
>>
>> Makes sense, but why are you providing clone implementations in point,
>> money, interval and NullObject instances? Shouldn't this already be
>> handled by PGObject's implementation?
>
> Yes, in all of those cases the clone() implementation in PGobject would
> do what is expected. I suppose I provided the method declarations and
> trivial implementations for clarity but they are not needed.
>

OK, patch applied.

Kris Jurka

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Oliver Jowett 2007-07-16 23:29:52 Re: Stream Copy for 8.1 - 8.3dev
Previous Message Kalle Hallivuori 2007-07-16 14:49:14 Re: Stream Copy for 8.1 - 8.3dev