Re: patch adding new regexp functions

From: Jeremy Drake <pgsql(at)jdrake(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Mark Dilger <pgsql(at)markdilger(dot)com>
Subject: Re: patch adding new regexp functions
Date: 2007-03-28 19:00:22
Message-ID: Pine.BSO.4.64.0703281154500.685@resin.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> Jeremy Drake wrote:
> > On Thu, 22 Mar 2007, Tom Lane wrote:
> >
> > > I'd vote for making this new code look like the rest of it, to wit
> > > hardwire the values.
> >
> > Attached please find a patch which does this.

I just realized that the last patch removed all usage of fcinfo in the
setup_regexp_matches function, so this version of the patch also removes
it as a parameter to that function.

--
Think of it! With VLSI we can pack 100 ENIACs in 1 sq. cm.!

Attachment Content-Type Size
regexp-funcs-hardcode-texttype-2.patch text/plain 4.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian G. Pflug 2007-03-28 19:13:21 Re: CREATE INDEX and HOT - revised design
Previous Message Simon Riggs 2007-03-28 18:48:58 Re: CREATE INDEX and HOT - revised design

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2007-03-28 19:15:20 Re: Arrays of Complex Types
Previous Message David Fetter 2007-03-28 18:48:57 Re: Arrays of Complex Types