| From: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Neil Conway <neilc(at)samurai(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-03-22 05:47:44 |
| Message-ID: | Pine.BSO.4.64.0703212241550.19070@resin.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Thu, 22 Mar 2007, Tom Lane wrote:
> AFAIR, the reason there's no TextPGetDatum (and ditto for lots of other
> datatypes) is lack of obvious usefulness. A function dealing with a
> "text *" doesn't normally have reason to convert that to a Datum until
> it returns --- and at that point PG_RETURN_TEXT_P is the thing to use.
> Do you have a counterexample, or does this just suggest that the regexp
> function patch needs some refactoring?
If you are asking why I have reason to convert text * to a Datum in cases
other than PG_RETURN_TEXT_P, it is used for calling text_substr functions
using DirectFunctionCallN. BTW, this usage of text_substr using
PointerGetDatum was copied from the pre-existing textregexsubstr function.
--
Malek's Law:
Any simple idea will be worded in the most complicated way.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-03-22 06:25:15 | Re: [PATCHES] Bitmapscan changes |
| Previous Message | ITAGAKI Takahiro | 2007-03-22 05:41:35 | LIKE optimization in UTF-8 and locale-C |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-03-22 06:25:15 | Re: [PATCHES] Bitmapscan changes |
| Previous Message | ITAGAKI Takahiro | 2007-03-22 05:41:35 | LIKE optimization in UTF-8 and locale-C |