| From: | Jeremy Drake <pgsql(at)jdrake(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Neil Conway <neilc(at)samurai(dot)com>, Mark Dilger <pgsql(at)markdilger(dot)com> |
| Subject: | Re: patch adding new regexp functions |
| Date: | 2007-02-18 23:56:08 |
| Message-ID: | Pine.BSO.4.64.0702181553300.18849@resin.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Sun, 18 Feb 2007, Tom Lane wrote:
> Jeremy Drake <pgsql(at)jdrake(dot)com> writes:
> > I will rename the functions regexp_split_to_(table|array) and I will add
> > an optional limit parameter to the regexp_split_to_table function, for
> > consistency and to avoid ordering concerns with LIMIT.
>
> I'd go the other way: get rid of the limit option all 'round. It seems
> like fairly useless complexity.
OK, here is what is hopefully the final version of this patch. I have
renamed the functions as above, and removed the optional limit parameter.
If there are no further complaints, this should be ready to apply.
--
It is the business of little minds to shrink.
-- Carl Sandburg
| Attachment | Content-Type | Size |
|---|---|---|
| regexp-split-matches-documented-renamed.patch | text/plain | 44.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Sherry | 2007-02-19 02:34:17 | Re: TopPlan, again |
| Previous Message | Tom Lane | 2007-02-18 23:27:11 | Re: patch adding new regexp functions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2007-02-19 07:38:09 | Re: WIP patch - INSERT-able log statements |
| Previous Message | Tom Lane | 2007-02-18 23:27:11 | Re: patch adding new regexp functions |