Re: patch: fix ResultSet.isLast and friends with cursor-based

From: Kris Jurka <books(at)ejurka(dot)com>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: patch: fix ResultSet.isLast and friends with cursor-based
Date: 2004-04-10 13:55:00
Message-ID: Pine.BSO.4.56.0404100854440.13327@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Sat, 10 Apr 2004, Oliver Jowett wrote:

> The attached patch fixes (and adds testcases for) the various resultset
> position querying methods (isFirst, isLast, isBeforeFirst, isAfterLast)
> that can be called on any resultset. The current driver does not handle
> these methods correctly when a TYPE_FORWARD_ONLY resultset that is
> backed by a cursor is used.
>
> isLast() may be more expensive after this patch (as it may need to do a
> FETCH), but this cost is warned about in the JDBC javadoc.
>
> A couple of other changes also in this patch:
>
> - prevent use of relative row movement methods (relative, next,
> previous) when on the insert row -- as I read the spec these shouldn't
> be allowed.
> - reset onInsertRow whenever an absolute row positioning method is called.
>

Patch Applied.

Kris Jurka

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Kris Jurka 2004-04-10 14:04:07 Re: Connection Idle in transaction
Previous Message Sica, David (David) 2004-04-10 01:40:06 Re: PostgreSQL 7.4.2 and pg74.1jdbc3.jar