Skip site navigation (1) Skip section navigation (2)

Re: Patch to remove sort files, temp tables, unreferenced files

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch to remove sort files, temp tables, unreferenced files
Date: 2001-05-30 19:21:38
Message-ID: Pine.BSF.4.33.0105301621000.82504-100000@mobile.hub.org (view raw or flat)
Thread:
Lists: pgsql-patches
I agree with Tom's arguments ...

On Wed, 30 May 2001, Bruce Momjian wrote:

>
> OK, Tom doesn't like the majority of my patch.  I think it has value.
> Would others like to comment?
>
>
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > >> No we don't.  I'm not convinced that we have a problem at all anymore.
> >
> > > We already know that crashes will leave these files around, and as we
> > > start using file versioning for CLUSTER and DROP COLUMN, I expect those
> > > orphaned files to continue.
> >
> > I don't.  The intention (not yet implemented, but Vadim's referred to it
> > repeatedly) is that relation file creation/deletion will be logged in
> > WAL, and so it can be redone or undone after a crash.  That seems a much
> > more secure approach than anything you've proposed in this thread.
> >
> > Temp files won't be logged in WAL, but a startup-time cleanup seems
> > sufficient to deal with them.
> >
> > > You are correct.  I didn't realized that after I check the shared memory
> > > for the pid, another backend could start with the pid I was checking and
> > > create a sort file.  The sort code doesn't do O_EXCL,
> >
> > ... quite deliberately ... you might want to add a comment to that
> > effect in OpenTemporaryFile.
> >
> > 			regards, tom lane
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: Have you searched our list archives?
> >
> > http://www.postgresql.org/search.mpl
> >
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org           secondary: scrappy(at){freebsd|postgresql}.org


In response to

pgsql-patches by date

Next:From: Ian Lance TaylorDate: 2001-05-30 19:22:30
Subject: Re: Support for %TYPE in CREATE FUNCTION
Previous:From: Jan WieckDate: 2001-05-30 18:39:26
Subject: Re: Support for %TYPE in CREATE FUNCTION

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group