Re: [HACKERS] freefuncs.c is never called from anywhere!?

On Mon, 31 Jan 2000, Peter Eisentraut wrote:

> On Mon, 31 Jan 2000, The Hermit Hacker wrote:
>
> > On Mon, 31 Jan 2000, Peter Eisentraut wrote:
> >
> > > On Sat, 29 Jan 2000, Bruce Momjian wrote:
> > >
> > > > However, I can't find any macro that uses this like makeNode does with
> > > > its pasteing. I would perhaps move it to a _deadcode directory and see
> > > > what happens. Or should we enable it?
> > >
> > > Please no more _deadcode. Why do we have CVS?
> > >
> > > (In the same spirit it would also be nice to tag NOT_USED sections with a
> > > version number, so it could be yanked two or three releases past.)
> >
> > Why not just yank it period? 'cvs diff' will show what was yanked, and
> > the log message could say just 'yanked NOT_USED code from source tree'...
>
> I *suspect* the purpose of some of these sections is that if it turns out
> somebody needed them for their application, we could just tell them to
> re-enable them there and there. If this is the case, then it has gone way
> past abuse already, though. Some parts of been NOT_USED for many years and
> most likely don't work anymore.

IMHO, if you want to take the time to do it, yank it. we have a cvs
history of everything we do, so it isn't as if its permanently lost, and,
as you say, with all the changes that have gone around some of the
NOT_USED code, they are most likely not even valid/working anymore :)

Makes for a good time to do clean up ... before beta and/or major release
...

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org