Skip site navigation (1) Skip section navigation (2)

RE: [HACKERS] freefuncs.c is never called from anywhere!?

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgreSQL(dot)org>
Subject: RE: [HACKERS] freefuncs.c is never called from anywhere!?
Date: 2000-01-30 06:05:13
Message-ID: NDBBIJLOILGIKBGDINDFIEIGCCAA.Inoue@tpf.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
> -----Original Message-----
> From: owner-pgsql-hackers(at)postgreSQL(dot)org
> [mailto:owner-pgsql-hackers(at)postgreSQL(dot)org]On Behalf Of Tom Lane
> 
> I was rather bemused to discover just now that the node-freeing
> functions in nodes/freefuncs.c are never called from anywhere;
> in fact, the module hasn't got a single exported entry point!
> 
> (I expect that freeObject() is supposed to be an external entry
> point; perhaps it got demoted to a static during one of Bruce's
> periodic get-rid-of-unreferenced-global-symbols passes.)
> 
> So much for all that tedious labor to maintain the freeXXX functions
> every time we update a node type ;-)
>

As far as I see,freeObject() has a fundamental problem.
Probably it couldn't free multiple references safely.

Regards.

Hiroshi Inoue
Inoue(at)tpf(dot)co(dot)jp

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2000-01-30 06:32:51
Subject: Re: [HACKERS] freefuncs.c is never called from anywhere!?
Previous:From: Tom LaneDate: 2000-01-30 04:18:38
Subject: Re: ImmediateSharedRelationCacheInvalidate considered harmful

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group