From: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
---|---|
To: | "'jm(dot)poure(at)freesurf(dot)fr'" <jm(dot)poure(at)freesurf(dot)fr> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Escaping quotes and double-quotes problem |
Date: | 2002-02-24 22:10:19 |
Message-ID: | FED2B709E3270E4B903EB0175A49BCB10475F2@dogbert.vale-housing.co.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
> -----Original Message-----
> From: Jean-Michel POURE [mailto:jm(dot)poure(at)freesurf(dot)fr]
> Sent: 24 February 2002 21:00
> To: Dave Page
> Cc: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Escaping quotes and
> double-quotes problem
>
>
> Le Dimanche 24 Février 2002 21:05, Dave Page a écrit :
> > Having said that, the function update code doesn't do that
> (Add does)
> > so I've comitted a fix for that.
> Thanks. I checked-out from CVS to get your fix.
>
> *** Please remove your fix ***, it's not in
> > the right place and will probably cause excessive quoting in some
> > cases.
> Do you mean I should also remove my fix in Functions.cls?
Yes please. The Source property should return the code that the user typed
in in the first place (i.e. with the doubled quotes). By keeping the Source
correct, then the SQL property will work with no modification, as will
frmFunction in pgAdmin which displays/updates the Source property, not the
SQL. If the fix is in the SQL property, then the quotes will be lost when
the user edits or displays the function.
Regards, Dave.
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2002-02-24 22:46:06 | Re: Working oin pgAdmin2 |
Previous Message | Jean-Michel POURE | 2002-02-24 21:39:14 | pgAdmin2 UTF-8 support |