Re: Implemented current_query

From: Tomas Doran <bobtfish(at)bobtfish(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Implemented current_query
Date: 2007-05-12 02:16:03
Message-ID: F76AB90C-259D-4C2E-9AFE-0D8E8A26847D@bobtfish.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On 10 May 2007, at 03:09, Alvaro Herrera wrote:
> FWIW I think you should still provide dblink_current_query, even if
> it's
> only a wrapper over current_query(), for backwards compatibility.

Good point. Done as suggested (I think, or did you mean also the
change of instances to use current_query()?). Replaced
dblink_current_query with an SQL procedure wrapper, I assume that's
the most efficient way of doing it?

> Also, typically we don't remove items from the TODO list. We mark
> them
> as "done" prepending them with a dash. Patch authors are not expected
> to do it either (though I don't see it be a problem if they did).

Not quite sure what you're suggesting (which way round), so I just
didn't do it (as you said I'm not expected to).

> Doesn't matter ... just make sure duplicate_oids doesn't report a
> problem. unused_oids is useful to find, err, unused OIDs.

Ahh, hadn't found those, thanks. They're in the dev FAQ too, *blush*.
I need this for something I'm doing at $ork, and thought I'd
implement it in the backend, as well as a .so, it's been a learning
experience :)

>>> * AFAIK debug_query_string() still does the wrong thing when the
>>> user
>>
>> Should that be added to the TODO list?
>
> Probably ...

Done!

Cheers
Tom

Attachment Content-Type Size
pgsql-current_query.patch application/octet-stream 11.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-05-12 07:35:27 Re: Seq scans roadmap
Previous Message Heikki Linnakangas 2007-05-11 21:59:59 Re: Seq scans roadmap

Browse pgsql-patches by date

  From Date Subject
Next Message Robert Treat 2007-05-12 02:18:30 Re: Have vacuum emit a warning when it runs out of maintenance_work_mem
Previous Message Tom Lane 2007-05-12 00:57:41 Re: updated WIP: arrays of composites