Re: New to_timestamp implementation is pretty strict

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New to_timestamp implementation is pretty strict
Date: 2008-12-01 14:45:21
Message-ID: F456DC32-06EB-4546-8683-7F0BE4E55B1F@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Dec 1, 2008, at 1:08 PM, Heikki Linnakangas wrote:

> postgres=# SELECT to_timestamp('29-12-2005 01:02:3', 'DD-MM-YYYY
> HH24:MI:SS'); -- doesn't work
> ERROR: source string too short for "SS" formatting field
> DETAIL: Field requires 2 characters, but only 1 remain.
> HINT: If your source string is not fixed-width, try using the "FM"
> modifier.
>
> I think the end of string should be treated like a field separator,
> colon in this example, and we should accept both of the above.
> Opinions?

I'm generally in favor of being generous in the input one can accept,
but in this case it seems ambiguous to me. Is that supposed to be :30
or :03? There's no way to tell.

My $0.02.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-12-01 14:49:38 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Previous Message Robert Haas 2008-12-01 14:40:43 Re: Simple postgresql.conf wizard