Re: BUG #4056: problem creating function with domain argument

Hi

Just a question..

The type was declared as follows:

CREATE DOMAIN "dt_0" AS varchar(32)
NULL;

So why does the query respond with 36?

Regards

-----Original Message-----
From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
Sent: Thursday, March 27, 2008 10:53 AM
To: Dave Page
Cc: Eric P. Melbardis; pgsql-bugs(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #4056: problem creating function with domain
argument

"Dave Page" <dpage(at)pgadmin(dot)org> writes:
> On Tue, Mar 25, 2008 at 5:37 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> ... It looks to me like pgAdmin is mistakenly
>> thinking that a domain has type modifiers.

> pgAdmin is using format_type() with a query like:

> postgres=# SELECT oid, format_type(oid, typtypmod) AS typname FROM
> pg_type where oid = 'dt_0'::regtype;
> oid | typname
> -------+----------
> 35130 | dt_0(36)
> (1 row)

> I would expect it to format the type appropriately.

No, the above is entirely wrong. typtypmod is the typmod that goes with
the domain's base type, not with the domain itself. You got away with
this mistaken code before 8.3 because format_type just silently ignored
its typmod argument for all but a very small number of types. But now
the default behavior is to print the typmod.

When looking at a domain type, format_type(typbasetype,typtypmod)
would be a sane thing to do. But that typmod isn't to be attached
to the domain itself.

regards, tom lane