Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Interval aggregate regression failure (expected seems

From: Michael Glaesemann <grzm(at)seespotcode(dot)net>
To: Michael Glaesemann <grzm(at)seespotcode(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paesold <mpaesold(at)gmx(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Interval aggregate regression failure (expected seems
Date: 2006-08-29 15:02:41
Message-ID: ED3C135A-9022-4655-AB8C-65658E2567D2@seespotcode.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Aug 29, 2006, at 15:38 , Michael Glaesemann wrote:

> I think I've got it. I plan to update the regression tests this  
> evening, but I wanted to post what I believe is a solution.

I've cleaned up the patch a bit in terms of whitespace, comments, and  
parens. I've also updated the interval and horology regression tests.  
The horology tests needed updating because I added 5 rows to  
INTERVAL_TBL. I didn't check the math for every row of time(tz |  
stamp | stamptz)/interval arithmetic in the horology tests as I think  
problems in this area would have shown up before. Does that make  
sense or it just rationalization on my part?

Both with and without --enable-integer-datetimes pass the regression  
tests.

Thanks!

Michael Glaesemann
grzm seespotcode net



Attachment: interval_muldiv.patch
Description: application/octet-stream (127.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Zoltan BoszormenyiDate: 2006-08-29 15:24:13
Subject: Re: [HACKERS] Performance testing of COPY (SELECT)
Previous:From: Magnus HaganderDate: 2006-08-29 14:59:50
Subject: GRANT role docs inconsistency

pgsql-patches by date

Next:From: Zoltan BoszormenyiDate: 2006-08-29 15:24:13
Subject: Re: [HACKERS] Performance testing of COPY (SELECT)
Previous:From: Andrew DunstanDate: 2006-08-29 14:50:29
Subject: Re: python / 7.4 / FC5 / x86_64

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group