Skip site navigation (1) Skip section navigation (2)

Suggestion for MSVC build

From: "Chuck McDevitt" <cmcdevitt(at)greenplum(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Suggestion for MSVC build
Date: 2007-09-24 02:03:09
Message-ID: EB48EBF3B239E948AC1E3F3780CF8F8802A1B24F@MI8NYCMAIL02.Mi8.com (view raw or flat)
Thread:
Lists: pgsql-hackers
It seems like there isn't any good reason the perl scripts for the MSVC
build don't support readline

 

Readline for windows is available as part of the GnuWin32 project. 

 

http://gnuwin32.sourceforge.net/packages/readline.htm

 

It normally installs to "c:\Program Files\GnuWin32"

 

I'd update the scripts myself, but I'm not a PERL programmer.

From what I can see, you'd add another line to config.pl for readline,
and then add some stuff to  mkvcbuild.pm for psql  to do something like:

 

if ($solution->{options}->{readline})

    {

 
$psql->AddIncludeDir($solution->{options}->{readline} . '\include');

 
$psql->AddLibrary($solution->{options}->{readline} .
'\lib\readline.lib');

 
$psql->AddLibrary($solution->{options}->{readline} .
'\lib\history.lib');

}

 

And something to solution.pm in the part that builds pg_config.h that
looks something like:

 

if ($self->{options}->{readline})

                                {

                                                print O "#define
HAVE_LIBREADLINE 1\n";

                                                print O "#define
HAVE_READLINE_READLINE_H 1\n";

                                                print O "#define
HAVE_READLINE_HISTORY_H 1\n";

                                                print O "#define
USE_READLINE 1\n";

                                                print O "#define
USE_READLINE_STATIC 1\n";

                                }

(Not sure about the last line).

 

I don't know if this is a good idea, but I would think this would make
psql more "user-friendly" on windows.

 

Perhaps someone who understands readline and perl better than me might
want to take this on?

 

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-09-24 02:44:51
Subject: Re: Problem with MSVC install script
Previous:From: Chuck McDevittDate: 2007-09-24 01:50:53
Subject: Problem with MSVC install script

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group