Skip site navigation (1) Skip section navigation (2)

Re: Rev 4704

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>,"pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Rev 4704
Date: 2005-11-09 10:49:03
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4E7DE8A@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgadmin-hackers
 

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin(at)pse-consulting(dot)de] 
> Sent: 09 November 2005 10:20
> To: Dave Page; pgadmin-hackers
> Subject: Rev 4704
> 
> Dave,
> 
> I'm trying to make sense of your change of ShowTipOfTheDay's 
> type from 
> bool to int for 1.5. The type was changed to bool in 1.3, and I don't 
> see a reason to change it again.

As we discussed last week, it causes an assert in debug builds on
Windows as wx seems to be unable to cast from DWORD to bool. Even
deleting the registry key and allowing it to recreate it itself doesn't
help.

This was the only fix that seemed to make sense without the pain of
fixing wx. Note that other true/false registry keys are stored as
true/false strings - I didn't change to follow that convention as it
would definitely not be backwards compatible with existing DWORD values.

/D


Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2005-11-09 10:55:35
Subject: Re: SVN Commit by andreas: r4705 - branches/REL-1_4_0_PATCHES/pgadmin3
Previous:From: svnDate: 2005-11-09 10:41:31
Subject: SVN Commit by andreas: r4708 - branches/REL-1_4_0_PATCHES/pgadmin3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group