Skip site navigation (1) Skip section navigation (2)

Re: Continuing encoding fun....

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Hiroshi Saito" <saito(at)inetrt(dot)skcapi(dot)co(dot)jp>,<pgsql-odbc(at)postgresql(dot)org>
Cc: "Marko Ristola" <Marko(dot)Ristola(at)kolumbus(dot)fi>,"Johann Zuschlag" <zuschlag2(at)online(dot)de>,"Anoop Kumar" <anoopk(at)pervasive-postgres(dot)com>
Subject: Re: Continuing encoding fun....
Date: 2005-09-06 08:02:54
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4AC9EAB@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgsql-odbc
 

> -----Original Message-----
> From: Hiroshi Saito [mailto:saito(at)inetrt(dot)skcapi(dot)co(dot)jp] 
> Sent: 05 September 2005 18:35
> To: Dave Page; pgsql-odbc(at)postgresql(dot)org
> Cc: Marko Ristola; Johann Zuschlag; Anoop Kumar
> Subject: Re: [ODBC] Continuing encoding fun....
> 
> > Either way, we're certainly not going to release the 
> non-libpq version
> > any more.
> 
> Ok, I also think that it is accordant to reason.
> 
> > BTW, your version misses the changes to installer/psqlodbcm.wxs...
> 
> Uga... Sorry.
> 
> Ah.. I look at a part strange one.
> Please check it.:-)


Re patch:

--- connection.c.orig	Tue Sep  6 01:47:23 2005
+++ connection.c	Tue Sep  6 02:13:53 2005
@@ -1545,7 +1545,7 @@
 		if (self->unicode)
 		{
 			if (!self->client_encoding ||
-			    !stricmp(self->client_encoding, "UNICODE"))
+			    stricmp(self->client_encoding, "UNICODE"))
 			{
 				QResultClass	*res;
 				if (PG_VERSION_LT(self, 7.1))

The opposite of this change was made in 1.92 of connection.c:
http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/connection
.c?rev=1.92&content-type=text/x-cvsweb-markup

It seems to me that the current case is correct - in the Unicode driver
we *must* run with client_encoding = 'UNICODE' or it won't work
properly. That said, I wonder if we shouldn't just remove the if()
altogether, and unconditionally set the client encoding for the Unicode
driver.

Don't forget, this won't affect the ANSI/Multibyte case because it's
inside a "#ifdef UNICODE_SUPPORT".

What do you think Anoop?

Regards, Dave


Responses

pgsql-odbc by date

Next:From: Anoop KumarDate: 2005-09-06 08:53:16
Subject: Re: Continuing encoding fun....
Previous:From: Dave PageDate: 2005-09-06 07:32:20
Subject: Re: Using Which Driver [correct]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group