Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Appbundle-Support for 1.2

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
Cc: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>,<pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Appbundle-Support for 1.2
Date: 2005-05-16 12:25:04
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E490DE6E@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgadmin-hackers
Thanks, patch applied. 

> -----Original Message-----
> From: Raphaël Enrici [mailto:blacknoz(at)club-internet(dot)fr] 
> Sent: 15 May 2005 21:28
> To: Dave Page
> Cc: Florian G. Pflug; pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
> 
> Dave,
> 
> attached is the patch which both Florian and I think it solves the
> DESTDIR issue in Makefile.am.
> 
> Regards,
> Raphaël
> 
> Florian G. Pflug wrote:
> > Raphaël Enrici wrote:
> > 
> >>Dave Page wrote:
> >>
> >>>>From: blacknoz(at)club-internet(dot)fr 
> [mailto:blacknoz(at)club-internet(dot)fr] 
> >>>>
> >>>>Hi Dave, Florian,
> >>>>
> >>>>I just took a quick look to the patch provided by Florian. I 
> >>>>didn't try the build yet and I may be wrong, but to me it 
> >>>>does not handle the "DESTDIR" problem and refers to PREFIX, 
> >>>>not DESTDIR.
> >>>>However, I'll try that tonight. Florian, can you confirm you 
> >>>>were referring to DESTDIR and not PREFIX ?
> >>>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
> >>>
> >>>Gmake/automake/autoconf is all black magic for me, hence 
> why I'd rather
> >>>tackle one problem on on OS (that I don't have) at a time :-)
> >>
> >>So, let's continue the twist :)
> >>
> >>attached is the patch that works for me and keeps what was added by
> >>Florian. As I understand it, $(PREFIX) is the equivalent to "my"
> >>$(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
> >>replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref 
> from Makefile.am.
> >>
> >>Florian, what do you think about it?
> > 
> > 
> > Dave, please apply Rapahels correction of my patch - I was 
> just being
> > brain-dead ;-)
> > 
> > I meant to write "$(DESTDIR)" - but somehow I ended up typing 
> > "$(PREFIX)", and didn't notice because $(PREFIX) is undefined,
> > and this empty.
> > 
> > Sorry for the confusion
> > 
> > greetings, Florian Pflug
> > 
> > ---------------------------(end of 
> broadcast)---------------------------
> > TIP 6: Have you searched our list archives?
> > 
> >                http://archives.postgresql.org
> > 
> 
> 
> -- 
>  Raphaël Enrici			blacknoz(at)club-internet(dot)fr
>  -- ICQ: 207246758  / Jabber: blacknoz(at)jabber(dot)org --
>  -- Use Debian GNU/Linux http://www.debian.org/   --
>  -- Use pgAdmin          http://www.pgadmin.org/  --
> 

Responses

pgadmin-hackers by date

Next:From: Raphaël EnriciDate: 2005-05-16 13:58:09
Subject: Re: [PATCH] Appbundle-Support for 1.2
Previous:From: svnDate: 2005-05-16 12:24:49
Subject: SVN Commit by dpage: r4183 - trunk/pgadmin3/i18n

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group